Remove deprecation notations introduced in MathComp 2.0.0 #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
pi8027
force-pushed
the
cleanup-deprecation
branch
2 times, most recently
from
f20ea3e
to
f05b423
Compare
pi8027
changed the title
|
Thanks, this seems to require less overlays than I feared. |
|
@CohenCyril Would you mind taking care of real-closed (since you are working on its refactoring PR)? |
|
I am actually in the way and will provide a sed script in case it's of any use for others. |
pi8027
force-pushed
the
cleanup-deprecation
branch
from
f05b423
to
dc43284
Compare
pi8027
added a commit
to coq-community/fourcolor
that referenced
this pull request
Mar 28, 2024
pi8027
added a commit
to coq-community/bits
that referenced
this pull request
Mar 28, 2024
pi8027
added a commit
to coq-community/fourcolor
that referenced
this pull request
Mar 28, 2024
pi8027
added a commit
to coq-community/bits
that referenced
this pull request
Mar 28, 2024
pi8027
force-pushed
the
cleanup-deprecation
branch
from
dc43284
to
906475e
Compare
pi8027
added a commit
to math-comp/analysis
that referenced
this pull request
Mar 29, 2024
pi8027
added a commit
to coq-community/coqeal
that referenced
this pull request
Mar 29, 2024
pi8027
added a commit
to math-comp/analysis
that referenced
this pull request
Mar 29, 2024
pi8027
force-pushed
the
cleanup-deprecation
branch
2 times, most recently
from
2e4cff0
to
f8bd203
Compare
|
@CohenCyril (also @Tragicus) Since you are working on Abel and it seems to have a breakage not introduced in this PR (probably introduced in math-comp/real-closed#59), can you take a look at it? (No hurry. This PR won't be merged before #1166.) |
proux01
pushed a commit
to coq-community/coqeal
that referenced
this pull request
Mar 29, 2024
|
Yes, I will take a look at it shortly. |
|
Thanks! |
pi8027
force-pushed
the
cleanup-deprecation
branch
from
f8bd203
to
4b713fe
Compare
proux01
force-pushed
the
cleanup-deprecation
branch
from
4b713fe
to
c0ede76
Compare
proux01
changed the title
|
@pi8027 CI green, if you do the changelog, we can merge this |
pi8027
commented
Apr 9, 2024
pi8027
commented
Apr 9, 2024
pi8027
force-pushed
the
cleanup-deprecation
branch
from
c0ede76
to
be50e86
Compare
pi8027
commented
Apr 9, 2024
pi8027
changed the title
proux01
force-pushed
the
cleanup-deprecation
branch
from
9af220e
to
909cfee
Compare
proux01
changed the title
|
Thanks @pi8027 for all the work here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This PR removes deprecation notations introduced in MathComp 2.0. This helps us in making some files smaller.
Things done/to do
CHANGELOG_UNRELEASED.md[ ] added corresponding documentation in the headersCompatibility with MathComp 1.X
[ ] I added the labelTODO: MC-1 portto make sure someone ports this PR tothe
mathcomp-1branch or I already opened an issue or PR (please cross reference).Automatic note to reviewers
Read this Checklist and put a milestone if possible.