Replace all the CoInductives with Variants #204
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MathComp library uses many
CoInductive
commands to build non-recursive type families without generating inductive principles. I think that itVariant
commands (see https://coq.inria.fr/refman/language/gallina-specification-language.html#coq:cmd.variant).This patch simply replaces all the
CoInductive
commands withVariant
commands in the current master branch. This works well with Coq 8.8.1 in my environment. I will prepare the same pull requests forcoq/coq
(the Ssreflect plugin) andmath-comp/odd-order
if everyone agrees with this modification.