Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all the CoInductives with Variants #204

Merged

Conversation

pi8027
Copy link
Member

@pi8027 pi8027 commented Jul 12, 2018

The MathComp library uses many CoInductive commands to build non-recursive type families without generating inductive principles. I think that it

This patch simply replaces all the CoInductive commands with Variant commands in the current master branch. This works well with Coq 8.8.1 in my environment. I will prepare the same pull requests for coq/coq (the Ssreflect plugin) and math-comp/odd-order if everyone agrees with this modification.

@gares gares requested a review from CohenCyril July 12, 2018 15:09
@CohenCyril
Copy link
Member

I think this is a good idea, but AFAIK, the Variant vernac is available only for 8.8, so we should wait a few versions of Coq before integrating.

@pi8027
Copy link
Member Author

pi8027 commented Jul 14, 2018

The Variant command has been available since Coq 8.5beta1 (CHANGES). Currently, MathComp supports only Coq 8.6, 8.7, and 8.8. This change passed CI checks. So I think there is no need to wait.

@CohenCyril
Copy link
Member

Oh right! My mistake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants