Remove hint declarations using non-global definitions. #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gares
reviewed
Nov 19, 2019
gares
reviewed
Nov 19, 2019
|
I am a bit nervous about this ... |
|
@CohenCyril Alternatively we can define them inside the section if you prefer. Nonetheless, it seems that let-definitions are used pervasively in the mathcomp library. |
|
It seems to the release managers that this PR could make it to the upcoming release. Can you complete it? |
coqbot
added
the
needs: rebase
affeldt-aist
force-pushed
the
rm-constr-hint-decls
branch
from
b585edc
to
868722b
Compare
coqbot
removed
the
needs: rebase
affeldt-aist
force-pushed
the
rm-constr-hint-decls
branch
from
868722b
to
107954c
Compare
|
We are thinking about merging this PR by tomorrow if nobody disagrees. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
See coq/coq#7791.
Things done/to do
added corresponding entries inCHANGELOG_UNRELEASED.mdadded corresponding documentation in the headersAutomatic note to reviewers
Read this Checklist and make sure there is a milestone.