Non-distributive lattice structures #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@strub Can you be the assignee? |
|
Sure |
|
Can somebody assigned me? |
|
@strub @CohenCyril Thank you. |
pi8027
force-pushed
the
experiment/order-nondistr-lattice
branch
from
547eb6c
to
00f593f
Compare
|
I don't think I have that much to say about this PR. I am now using it for 1 month without any problem and the diff seems fine by me. IMO, it is ready for merge. |
|
Done. I think this should be OK, but I can wait for more feedback. |
strub
approved these changes
Jan 30, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This PR adds non-distributive lattice structures
latticeType,bLatticeType,tbLatticeType, andfinLatticeType, and big pack notations suggested by @CohenCyril. This PR was originally opened as PR #388, needed to be recreated to change the target branch fromexperiment/ordertomaster.Things done/to do
CHANGELOG_UNRELEASED.mdAutomatic note to reviewers
Read this Checklist and make sure there is a milestone.