Fixing permS0 and permS1 #482
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CohenCyril
added
kind: enhancement
|
@affeldt-aist and @ybertot this PR should be merge right after #221 is merged, I am not adding it directy to #221 not to disrupt the CI status while Assia is potentially reviewing it. |
This was referenced Apr 10, 2020
CohenCyril
removed
kind: enhancement
I changer my mind. The change is small enough I pushed directly to #221. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
permS0andpermS1should be phrased withall_equal_toto be really useful.Things done/to do
CHANGELOG_UNRELEASED.mdadded corresponding documentation in the headersAutomatic note to reviewers
Read this Checklist and make sure there is a milestone.