Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword a CHANGELOG entry introduced in #429 #495

Merged
merged 1 commit into from
May 5, 2020

Conversation

pi8027
Copy link
Member

@pi8027 pi8027 commented May 4, 2020

that explains an incompatibility between development versions, as I suggested in #429 (comment).

Motivation for this change
Things done/to do
  • [ ] added corresponding entries in CHANGELOG_UNRELEASED.md
  • [ ] added corresponding documentation in the headers
Automatic note to reviewers

Read this Checklist and make sure there is a milestone.

@gares
Copy link
Member

gares commented May 4, 2020

As per WG this need an update (instead of removing the entry, write how to migrate)

@CohenCyril CohenCyril added this to the 1.11.0 milestone May 4, 2020
that explains an incompatibility between development versions
@pi8027 pi8027 changed the title Remove a CHANGELOG entry introduced in #429 Reword a CHANGELOG entry introduced in #429 May 5, 2020
@pi8027
Copy link
Member Author

pi8027 commented May 5, 2020

Done.

Copy link
Member

@CohenCyril CohenCyril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this explanation

@CohenCyril CohenCyril merged commit 3515b33 into math-comp:master May 5, 2020
@pi8027 pi8027 deleted the post-cleaning-pr429 branch May 6, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants