Support multi-domain, ECC certificates, cluster mode #9
Conversation
|
Testing the previous version right now. Was going to open an issue to have full cluster support, but this is already implemented here. Any ideas on the timeframe to a release? |
|
It should be done in the following days. |
|
|
||
| if [ "${STATUS_CODE}" = "200" ]; then | ||
| # try get namespaces (cluster mode) | ||
| status_code=$(k8s_api_call "GET" /api/v1/namespaces 2>"${RES_FILE}") |
There was a problem hiding this comment.
Deployment cluster scoped will failed. Please update your code to manage this case.
Use local keyword for variables when needed.
There was a problem hiding this comment.
Deployment cluster scoped will failed. Please update your code to manage this case.
What error did you see?
There was a problem hiding this comment.
Use
localkeyword for variables when needed.
I don't think sh supports local.
There was a problem hiding this comment.
What error did you see?
Cluster scoped deployment will failed due to a call requesting all namespaces without having a clusterrole. Just try it.
I don't think sh supports local.
ash is the system shell used on busybox and local keyword are supported.
There was a problem hiding this comment.
Cluster scoped deployment will failed due to a call requesting all namespaces without having a clusterrole. Just try it.
If you set cluster to true you will have a ClusterRole. If you set cluster to false(which is default), the request will fail. This is expected and will not cause problems. I've tested on my cluster. Maybe you need a fresh install? See certs/templates/rolebinding.yaml.
There was a problem hiding this comment.
ash is the system shell used on busybox and local keyword are supported.
I'll look into this.
|
Support for multi namespaces has been added in a previous version where it supports role and clusterrole. |
I implemented the following feature and this branch is working well on my cluster, serving more than 10 ingresses across namespaces: