Update BaseProfile #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtezzele
reviewed
Mar 16, 2018
bladex/utils/__init__.py
Outdated
| @@ -0,0 +1,3 @@ | |||
| """ | |||
| utils init | |||
There was a problem hiding this comment.
This file can remain empty
bladex/utils/rbf.py
Outdated
| Wendland :math:`C^2` basis and Polyharmonic splines all defined and | ||
| implemented below. | ||
| """ | ||
| def __init__(self, radius): |
There was a problem hiding this comment.
add the basis as input parameter. See the corresponding module of pygem
bladex/utils/rbf.py
Outdated
|
|
||
| def reconstruct_f(basis, original_input, original_output, xx, yy, radius=10.0): | ||
| radial = RBF(radius=radius) | ||
| if basis == 'gaussian': |
There was a problem hiding this comment.
modifying the init of RBF this if then else should go away
bladex/utils/rbf.py
Outdated
| matrix[i][j] = self.basis(X1[i] - X2[j], self.radius) | ||
| return matrix | ||
|
|
||
| def reconstruct_f(basis, original_input, original_output, xx, yy, radius=10.0): |
There was a problem hiding this comment.
Use meaningful inputs name, and document the function
|
Ok, you can squash all the commits to one or few commits and then I'll merge. Don't worry for travis, I will fix it in another PR. |
Fix header title in the README check that outfile is string in plot method
add methods in BaseProfile for computing max thickness and max camber
…nstruct_f(), modify reconstruct_f() arguments to more meaningful names. Also provide documentation rbf provide example in the documentation cleaning __init__ in the subdirectory use numpy instead of math, for trig. functions apply code_formatter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.