Inclusion of Shaft and Propeller classes with tests (basic version) #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndem0
requested changes
Apr 7, 2021
mtezzele
reviewed
Apr 9, 2021
ndem0
reviewed
Apr 14, 2021
bladex/propeller.py
Outdated
| sewed_full_body = sewer.SewedShape() | ||
| self.sewed_full_body = sewer.SewedShape() | ||
|
|
||
| def generate_propeller_iges(self, propeller_and_shaft, display=False): |
There was a problem hiding this comment.
generate_iges for the method name (no reason to be redundant with "propeller" since the object itself is called Propeller)
ndem0
reviewed
Apr 14, 2021
bladex/propeller.py
Outdated
Comment on lines
71
to
74
| display, start_display, add_menu, add_function_to_menu = init_display() | ||
| display.DisplayShape(self.sewed_full_body, update=True) | ||
| start_display() |
There was a problem hiding this comment.
Why display when exporting? It looks much better to me have a separate method to display the propeller like>
my_custom_propeller = Propeller(...)
my_custom_propeller.display()
There was a problem hiding this comment.
I can change accordingly, thanks.
ndem0
reviewed
Apr 14, 2021
bladex/propeller.py
Outdated
| start_display() | ||
|
|
||
| def generate_propeller_stl(self, propeller_and_shaft, display=False): |
ndem0
reviewed
Apr 14, 2021
bladex/propeller.py
Outdated
Comment on lines
89
to
92
| display, start_display, add_menu, add_function_to_menu = init_display() | ||
| display.DisplayShape(self.sewed_full_body, update=True) | ||
| start_display() |
There was a problem hiding this comment.
I can change accordingly, thanks.
ndem0
reviewed
Apr 14, 2021
bladex/shaft.py
Outdated
| self.shaft_path = shaft_path | ||
| self.display = display | ||
|
|
||
| def generate_shaft_solid(self): |
ndem0
reviewed
Apr 14, 2021
bladex/shaft.py
Outdated
Comment on lines
43
to
46
| if self.display: | ||
| display, start_display, add_menu, add_function_to_menu = init_display() | ||
| display.DisplayShape(shaft_solid, update=True) | ||
| start_display() |
There was a problem hiding this comment.
I can change accordingly, thanks.
mtezzele
reviewed
Apr 15, 2021
bladex/propeller.py
Outdated
|
|
||
| :param shaft.Shaft shaft: shaft to be added to the propeller | ||
| :param blade.Blade blade: blade of the propeller | ||
| :param int n_blades: number of blades componing the propeller | ||
| :cvar OCC.Core.TopoDS.TopoDS_Solid shaft_solid: solid shaft | ||
| :cvar OCC.Core.TopoDS.TopoDS_Shell: propeller with shaft shell |
There was a problem hiding this comment.
missing name of the variable
bladex/propeller.py
Outdated
|
|
||
| :param string filename: path (with the file extension) where to store | ||
| the .stl CAD for the propeller and shaft |
There was a problem hiding this comment.
I think a tab is missing. Please check the doc is properly generated
| @@ -8,27 +8,25 @@ class Shaft(object): | |||
| """ | |||
| Bottom-up parametrized shaft construction. | |||
|
|
|||
| :param string shaft_path: path of a .iges file with stored shaft information. | |||
| :param bool display: if True, then display the shaft. Default value is False. | |||
| :cvar string filename: path (with the file extension) of a .iges file with | |||
There was a problem hiding this comment.
this is a param, not only a var
ndem0
approved these changes
Apr 16, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inclusion of Shaft and Propeller classes has to be viewed as a basic first version of them, based on already developed tools. Actually, the solid shaft is built reading from a file with stored shaft information. The propeller (including shaft) is obtained building on the Shaft and the already existing Blade class. I hope that this predisposition of codes could be useful as a starting point for further and future developments.