Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor revision of the Shaft class #66

Merged
merged 2 commits into from
May 18, 2021
Merged

Conversation

ggurioli
Copy link
Contributor

A minor revision of the Shaft class to read a shaft file stored in .stl/.iges formats (instead of the iges format only) is proposed. This can be useful in all those cases in which an stl shaft file is preferably considerable as the input shaft file to generate a propeller.

bladex/shaft.py Outdated
ext = os.path.splitext(self.filename)[1][1:]
if ext=='stl':
shaft_compound = read_stl_file(self.filename)
elif ext=='iges':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank spaces

bladex/shaft.py Outdated
iges_reader.TransferRoots()
shaft_compound = iges_reader.Shape()
ext = os.path.splitext(self.filename)[1][1:]
if ext=='stl':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank spaces

iges_reader = IGESControl_Reader()
iges_reader.ReadFile(self.filename)
iges_reader.TransferRoots()
shaft_compound = iges_reader.Shape()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please raise an error for different extensions

@ndem0 ndem0 merged commit f752c5a into mathLab:master May 18, 2021
@ggurioli ggurioli deleted the branch_shaft branch May 21, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants