Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusion of ANN method #131

Merged
merged 5 commits into from
Mar 3, 2021
Merged

Inclusion of ANN method #131

merged 5 commits into from
Mar 3, 2021

Conversation

ggurioli
Copy link
Contributor

@ggurioli ggurioli commented Feb 26, 2021

Last commit with files: Inclusion of ANN method 669c7cd

ezyrb/ann.py Outdated Show resolved Hide resolved
tests/test_ann.py Outdated Show resolved Hide resolved
ezyrb/ann.py Outdated Show resolved Hide resolved
ezyrb/ann.py Outdated Show resolved Hide resolved
ezyrb/ann.py Show resolved Hide resolved
ezyrb/ann.py Outdated Show resolved Hide resolved
ezyrb/ann.py Outdated Show resolved Hide resolved
ezyrb/ann.py Outdated Show resolved Hide resolved
ezyrb/ann.py Outdated Show resolved Hide resolved
ezyrb/ann.py Outdated Show resolved Hide resolved
ezyrb/ann.py Outdated Show resolved Hide resolved
ezyrb/ann.py Outdated Show resolved Hide resolved
ezyrb/ann.py Outdated Show resolved Hide resolved
ezyrb/ann.py Outdated Show resolved Hide resolved
@ndem0
Copy link
Member

ndem0 commented Mar 3, 2021

I think the optimizer should be passed in the init (as you did for the loss for example)

Right now it is not trivial as for the loss: the optimizer has to be constructed passing the model parameters, which means:

  • we can pass the class instead the instance, but the optimizer arguments are then the default ones (or you have to create a new class with the wanted parameters)
  • we can pass a dictionary with the optimizer class and all the arguments.

I prefer the second option, we plan to insert something like that in future

@ndem0 ndem0 merged commit 43fd50d into mathLab:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants