Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New approximation methods: KNeighbors and RadiusNeighbors #145

Merged
merged 1 commit into from
Mar 30, 2021
Merged

New approximation methods: KNeighbors and RadiusNeighbors #145

merged 1 commit into from
Mar 30, 2021

Conversation

fandreuz
Copy link
Member

@fandreuz fandreuz commented Mar 30, 2021 •
edited

This commit adds two new approximation methods: KNeighborsRegressor and RadiusNeighborsRegressor. They are wrappers for the sklearn classes KNeighborsRegressor and RadiusNeighborsRegressor.

The two methods are tested in isolation and together with the EZyRB interface.

mtezzele
mtezzele reviewed Mar 30, 2021
View reviewed changes
Copy link
Contributor

@mtezzele mtezzele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think you should extend the list __all__ in the __init__.py with the new modules.

ezyrb/neighborsregressor.py Outdated Show resolved Hide resolved
tests/test_radius_neighbors_regressor.py Show resolved Hide resolved
tests/test_k_neighbors_regressor.py Show resolved Hide resolved
@fandreuz
Copy link
Member Author

In my last commit I should have applied all the improvements you requested, @mtezzele.

@fandreuz
Copy link
Member Author

I updated __all__ and fixed some mispelled names in my last commit.

@ndem0 ndem0 merged commit c13f9bf into mathLab:master Mar 30, 2021
@fandreuz fandreuz deleted the k-n-neigh3 branch March 30, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtezzele mtezzele mtezzele left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fandreuz @mtezzele @ndem0