Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete multiple nodes #40

Merged
merged 6 commits into from
Nov 13, 2020
Merged

Delete multiple nodes #40

merged 6 commits into from
Nov 13, 2020

Conversation

martinateruzzi
Copy link
Contributor

@martinateruzzi martinateruzzi commented Nov 12, 2020 •
edited

The following PR includes:

  • added possibility to delete more than one node in simulate_element_perturbation (similar to area perturbation)
  • SOURCE and USER nodes are now deleted from self.services_SOURCE and self.services_USER lists respectively if removed from the graph
  • a bit of cleaning in check_before and check_after

Note: output files service_paths_element_perturbation.csv and service_paths_multi_area_perturbation.csv updated accordingly. Now the path is empty if SOURCE or USER is not in the graph. It is marked by "NO_PATH" if they are present in the graph but not connected.

TODOs:

  • residual service

ndem0
ndem0 reviewed Nov 12, 2020
View reviewed changes
grape/general_graph.py Outdated Show resolved Hide resolved
@ndem0 ndem0 merged commit 32fe624 into mathLab:master Nov 13, 2020
@martinateruzzi martinateruzzi deleted the delete_multiple_nodes branch November 13, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndem0 ndem0 ndem0 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martinateruzzi @ndem0