-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't install from ego in GS 3.4 #3
Comments
Oh my goodness thank you so much! Question - what particular version of GNOME shell do you have, 3.4.1 or 3.4.2? I had another user report this error on 3.4.2 but I can't reproduce on 3.4.1, and have been having a lot of difficulty trying to work out where the problem is since I don't have a 3.4.2 computer. (By the way - how did you get 3.4.2? I have a spare laptop that I am thinking of installing it on for testing extensions). |
Also, can you verify that commenting out this line (and setting PinchType to something other than METACITY) fixes the problem? |
Note to self for later when I'm on 3.4 instead of 3.2 - org.gnome.desktop.wm.preferences 'theme'. |
I'm using GNOME 3.4.2 on Arch Linux. Yeah, disabling 'do-metacity' option fixes the problem completely. And when I enable it, 'theme' variable becomes null and the script crashes in a few lines later. Also setting PinchType to different values doesn't change anything for me. In this case null variables are handled correctly I guess. Except for this issue the extension works like a charm (especially together with Maximus). Thanks a lot for such an amazing extension! :) |
Thank you muchly sir - as I mentioned I had another user report this about a week ago and it has been driving me crazy since I can't reproduce it and don't have 3.4.2. I'll get on to a fix over the weekends (use dconf key org.gnome.desktop.wm.preferences 'theme' if possible, then gconf '/apps/metacity/general/theme' if possible, but in either case fail gracefully). |
On my updated Fedora 17 x64, the same error:Error: invalid element in string array' as toiffel metioned, on my fedora, 【GConf.Client.get_default().get_string("/apps/metacity/general/theme");】will return null. I use gconf-editor and dconf-editor but can't find the path 【"/apps/metacity/general/theme"】 anyway, the condition for 【theme == null】should be checked. and with this check, there is Only benefits。 |
…branch): look up dconf before gconf, handle 'null' themes gracefully
(reopening until it gets merged into the GNOME 3.4 branch - will test when I get home and have access to 3.4.1) |
Actually the extension is downloaded to ~/.local/share/gnome-shell/extensions properly but fails to start with 'Error: invalid element in string array' message.
After doing some debugging I've found the problematic source line (extension.js:154)
AFAIK since GNOME 3.4 you should use GSettings for getting metacity theme, not gconf. This should fix the issue.
The text was updated successfully, but these errors were encountered: