Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add survey banner #93

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Add survey banner #93

merged 3 commits into from
Sep 21, 2023

Conversation

ghislaineguerin
Copy link
Contributor

Fixes #90

@ghislaineguerin ghislaineguerin marked this pull request as ready for review September 4, 2023 12:04
@ghislaineguerin ghislaineguerin added the status: review In review label Sep 4, 2023
@seancolsen
Copy link
Contributor

I don't intend to review this PR, but I do have some comments pending on the email thread which I'm still composing. I think it's fine for Pavish to review this PR now, but I'd like to request that we hold off on deploying this change to the live site until we've settled the review of the survey over email.

On the email thread, @ghislaineguerin said:

We can always revisit and make changes

I share this sentiment with other things we publish like our website, documentation, and even Mathesar itself — but not surveys. I think it's fine to make small typo-fixing adjustments to surveys as they're running, but I've experienced situations in the past where larger structural changes to surveys have led to significant complications. Analyzing survey results is much easier if all the submissions are structurally consistent. Also, while I would expect people to visit our marketing site periodically, I would not expect them to open the survey link more than once. With each person, we likely have multiple opportunities to ask them to fill out the survey, but only one chance for them to actually fill it out. So I think it's worth placing a very high priority on up-front effort that will help avoid the need to adjust the survey while it's running, even if that effort delays the publication of the survey.

@pavish
Copy link
Member

pavish commented Sep 8, 2023

I agree with Sean, and I'm holding off merging until we have a consensus on the mail thread.

@ghislaineguerin
Copy link
Contributor Author

@seancolsen I went ahead and used your suggestion. I think the shorter labels might be easier to understand.
@pavish you can now review this.

@pavish pavish merged commit f5c7285 into master Sep 21, 2023
1 check passed
@pavish pavish deleted the survey-banner branch September 21, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Add Survey Banner to Website
3 participants