Editing Records within a View #653
Replies: 6 comments 6 replies
-
@ghislaineguerin I have a bunch of questions/comments: (1) What is the logic for when we show the form and when we allow the user to edit-in-place while adding a record? Can the user access the form if they prefer to use that? (2) I don't see any design for removing a record in the prototype. Also, while designing this, we need to address the potential confusion a user might have about deleting records from views vs. tables. They may think they are only deleting a row from the view but we are deleting all records referencing the row from the underlying table. We need some form of confirmation that says "this will delete record X from table A and record Y from table B, are you sure?" This is not as much of an issue for adding records because they can always "undo" adding records by deleting them, but they cannot do the opposite. Also, just in case this is not clear, they will be deleting an entire row, they cannot delete just one record from the row if each row consists of multiple records. (3) The non-updatable view looks good for cases where we can find the underlying tables. In some cases, we may not be able to identify which tables a column comes from automatically, so those won't be able to be edited at all. We need a design for this too. (4) Generally, I think in views, we need to think about rows vs. records. A row may be composed of multiple (partial) records or just one record. This goes for adding and deleting (not so much for editing existing values). (5) I still don't see an indicator for unsaved changes. I might be missing it if it's there. (6) The column drag and drop looks good, but we also need an indicator for changes not being saved. This might be the same feedback as (5). (7) I'm not sure what the "Global Updates" section is referring to and I'm not sure how to review it. |
Beta Was this translation helpful? Give feedback.
-
Overall, I think this makes sense. I like the record editing sidebar. I have a couple concerns:
|
Beta Was this translation helpful? Give feedback.
-
I was looking through the combined view flow in the above UX prototype, and it looks pretty good. I have a few concerns:
|
Beta Was this translation helpful? Give feedback.
-
@kgodey regarding the non-editable views. I assume since we can't reference the tables nor add new columns or records, users will have limited functionality, such as filter, sort, and group. However, I'm not sure if we allow them to save that view with the filters as that would effectively 'edit' the view, wouldn't it? |
Beta Was this translation helpful? Give feedback.
-
@kgodey I want to confirm the behavior for editing records based on our discussion yesterday: Editing or Adding Records to a ViewA view with columns from multiple tables will display the table references in the new record row. Each cell will specify the table to which a record is being added. The edit formEditing any of the cells will prompt the record form and allow the user to edit all of the record fields for that table. QuestionIn this scenario, the foreign key for 'releaseName' exists in the 'artist' table as 'releaseId' Should we allow them to swap a record? Meaning that we'd be modifying the 'artist' table? Also, to confirm, do we want to have cancel and update buttons for dropdown actions or save on close? |
Beta Was this translation helpful? Give feedback.
-
Based on the new action plan from the 2021-10-15 meeting, we're going to update the requirements for issues in the milestone. I'm marking this discussion done, we'll start new discussions for further updates. |
Beta Was this translation helpful? Give feedback.
-
The design for issue #456 is ready for review. Please follow the Review Guidelines and make sure to review before the set deadline expires.
Document
https://wiki.mathesar.org/en/design/specs/eding-view-records
Reviewers
@kgodey @pavish @mathemancer Your review is required.
Feedback from the community is also welcome. Contributors can find more context about Mathesar's design strategy here.
Deadline
The deadline for submitting feedback is set 2 days from now, on Tuesday 14.
Beta Was this translation helpful? Give feedback.
All reactions