Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add E2E test for renaming a table #1124

Closed
Tracked by #1122
seancolsen opened this issue Mar 2, 2022 · 2 comments · Fixed by #1180
Closed
Tracked by #1122

Add E2E test for renaming a table #1124

seancolsen opened this issue Mar 2, 2022 · 2 comments · Fixed by #1180
Assignees
@A1O
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Milestone
[06.1] 2022-03 im...

Comments

@seancolsen
Copy link
Contributor

Context

See #1122 for more info and instructions on writing E2E tests.

This test

Write an E2E test which asserts that "renaming a table" works as-expected. Here's a visual demo of what the test should do:

Peek 2022-03-02 16-44

Tips

  • Assert that the modal closes, that the tab title updates, and that the entry in the sidebar updates
@seancolsen seancolsen added ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this labels Mar 2, 2022
@seancolsen seancolsen added this to the [12.1] 2022-05 improvements milestone Mar 2, 2022
@seancolsen seancolsen mentioned this issue Mar 2, 2022
Closed
9 tasks
@A1O
Copy link
Contributor

A1O commented Mar 11, 2022

I’d like to work on this issue.

@seancolsen
Copy link
Contributor Author

Thanks @A1O! I've assigned it to you. Let us know if you have any questions.

@kgodey kgodey added status: started and removed ready Ready for implementation labels Mar 11, 2022
@A1O A1O mentioned this issue Mar 16, 2022
Merged
7 tasks
@kgodey kgodey modified the milestones: [12.1] 2022-05 improvements, [06.1] 2022-03 improvements Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@A1O A1O

Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
[NO LONGER USED] Mathesar work tracker
Archived in project
Milestone
[06.1] 2022-03 improvements
Development

Successfully merging a pull request may close this issue.

E2E test for renaming a table
3 participants
@seancolsen @kgodey @A1O