Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E test for trying to convert a text column of words to a number column #1129

Closed
Tracked by #1122
seancolsen opened this issue Mar 2, 2022 · 2 comments · Fixed by #1164
Closed
Tracked by #1122

Add E2E test for trying to convert a text column of words to a number column #1129

seancolsen opened this issue Mar 2, 2022 · 2 comments · Fixed by #1164
Assignees
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory

Comments

@seancolsen
Copy link
Contributor

Context

See #1122 for more info and instructions on writing E2E tests.

This test

Write an E2E test which asserts that "trying to convert a text column of words to a number column" fails. Here's a visual demo of what the test should do:

Peek 2022-03-02 17-01

Tips

@seancolsen seancolsen added ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this labels Mar 2, 2022
@seancolsen seancolsen added this to the [12.1] 2022-05 improvements milestone Mar 2, 2022
@ManishShah120
Copy link
Contributor

I would like to work on this issue, 👍

@kgodey kgodey added status: started and removed ready Ready for implementation labels Mar 11, 2022
@kgodey
Copy link
Contributor

kgodey commented Mar 11, 2022

Thanks @ManishShah120, go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants