Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all command in local development contribution guide to use the correct container #2693

Closed
silentninja opened this issue Mar 16, 2023 · 6 comments · Fixed by #2696
Closed
Assignees
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation type: bug Something isn't working work: documentation Improvements or additions to documentation
Milestone

Comments

@silentninja
Copy link
Contributor

Description

Our docker containers for local development have changed from mathesar_service to mathesar_service_dev. This isn't reflected in the documentation

Expected behavior

The commands mentioned in documentation should use the correct Mathesar development container

@silentninja silentninja added type: bug Something isn't working work: documentation Improvements or additions to documentation ready Ready for implementation labels Mar 16, 2023
@silentninja silentninja added this to the Backlog milestone Mar 16, 2023
@pavish pavish added good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this labels Mar 16, 2023
manavana-pierroldin pushed a commit to manavana-pierroldin/mathesar that referenced this issue Mar 16, 2023
@Sukshan
Copy link
Contributor

Sukshan commented Mar 17, 2023

Can I work on this issue @silentninja

@pavish
Copy link
Member

pavish commented Mar 17, 2023

@Sukshan Sure, go ahead!

@pavish
Copy link
Member

pavish commented Mar 17, 2023

@Sukshan Sorry about the hasty assignment, it looks like there was a PR open for it already by @manavana-pierroldin: #2696

Please look for other open issues.

@manavana-pierroldin It would be helpful if you commented on the issues you're planning to work on, so that we can assign them to you.

@Sukshan
Copy link
Contributor

Sukshan commented Mar 17, 2023

No issues @pavish , I will search for another issue to work on.

@rajatvijay
Copy link
Contributor

@manavana-pierroldin could you please comment on this issue, so that we can assign this to you? Thanks!

@manavana-pierroldin
Copy link

This issue is already taken

pavish added a commit that referenced this issue Mar 21, 2023
…-mathesar-service-dev

Update all command in local development contribution guide to use the correct container #2693
seancolsen pushed a commit that referenced this issue Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation type: bug Something isn't working work: documentation Improvements or additions to documentation
Projects
No open projects
5 participants