Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Critical regression: Record page widgets break entirely #2717

Closed
pavish opened this issue Mar 20, 2023 · 4 comments
Closed

Critical regression: Record page widgets break entirely #2717

pavish opened this issue Mar 20, 2023 · 4 comments
Assignees
@pavish
Labels
priority: urgent Blocks other ongoing work ready Ready for implementation restricted: maintainers Only maintainers can resolve this issue type: bug Something isn't working work: frontend Related to frontend code in the mathesar_ui directory
Milestone
v0.1.1

Comments

@pavish
Copy link
Member

pavish commented Mar 20, 2023 •
edited

Description

  • Reorder columns frontend #2213 introduces a bug which sets the widget table as the same as the current open table. This commit: cf62dbf
  • This introduces a regression that breaks record page widgets.
  • To reproduce the bug: Open record page for a record of a table which has links from other tables.
@pavish pavish added type: bug Something isn't working work: frontend Related to frontend code in the mathesar_ui directory ready Ready for implementation restricted: maintainers Only maintainers can resolve this issue priority: urgent Blocks other ongoing work labels Mar 20, 2023
@pavish pavish added this to the v0.1.1 milestone Mar 20, 2023
@pavish pavish self-assigned this Mar 20, 2023
@pavish pavish mentioned this issue Mar 20, 2023
Closed
@pavish pavish changed the title Record page widgets break entirely - critical regression from https://github.com/centerofci/mathesar/pull/2213 Critical regression: Record page widgets break entirely Mar 20, 2023
@seancolsen
Copy link
Contributor

To reproduce the bug: Open record page for a record of a table which has links from other tables.

@pavish can you elaborate? I want to make sure I understand. After you open the record page, what is your expected behavior, and what is your observed behavior?

@pavish
Copy link
Member Author

pavish commented Mar 20, 2023 •
edited

@seancolsen

Open a record from a table which is linked from other tables.

Screenshot 2023-03-20 at 4 45 02 PM

In the above screenshot you can see that the widgets fail to load because instead of the linked tables it's trying to open the parent table, and adds a filter to itself.

This change from the PR is the cause:

          <TableWidget {table} {fkColumn} {recordId} />

was changed to:

          <TableWidget {recordId} table={currTable} {fkColumn}  />

Instead of passing the linked table, the parent table is passed here.

@seancolsen
Copy link
Contributor

I see. Thanks @pavish

@pavish pavish mentioned this issue Mar 21, 2023
Merged
7 tasks
@seancolsen seancolsen mentioned this issue Mar 21, 2023
Merged
7 tasks
@pavish
Copy link
Member Author

pavish commented Mar 21, 2023

Fixed by #2731

@pavish pavish closed this as completed Mar 21, 2023
@seancolsen seancolsen mentioned this issue Mar 23, 2023
Closed
AlekLefebvre pushed a commit to AlekLefebvre/mathesar that referenced this issue Apr 1, 2023
fix mathesar-foundation#2717
f64fdd5
@AlekLefebvre AlekLefebvre mentioned this issue Apr 20, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavish pavish

Labels
priority: urgent Blocks other ongoing work ready Ready for implementation restricted: maintainers Only maintainers can resolve this issue type: bug Something isn't working work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
[NO LONGER USED] Mathesar work tracker
Archived in project
Milestone
v0.1.1
Development

No branches or pull requests
2 participants
@seancolsen @pavish