Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Critical regression: Table cell keyboard navigation breaks after reordering columns #2718

Closed
pavish opened this issue Mar 20, 2023 · 1 comment
Closed

Critical regression: Table cell keyboard navigation breaks after reordering columns #2718

pavish opened this issue Mar 20, 2023 · 1 comment
Assignees
@pavish
Labels
priority: urgent Blocks other ongoing work ready Ready for implementation restricted: maintainers Only maintainers can resolve this issue type: bug Something isn't working work: frontend Related to frontend code in the mathesar_ui directory
Milestone
v0.1.1

Comments

@pavish
Copy link
Member

pavish commented Mar 20, 2023

Description

  • Reorder the columns of a table
  • Navigate the cells using keyboard arrow keys
  • Notice that the navigation does not work properly
  • This regression was possibly introduced in Reorder columns frontend #2213
@pavish pavish added type: bug Something isn't working work: frontend Related to frontend code in the mathesar_ui directory ready Ready for implementation restricted: maintainers Only maintainers can resolve this issue priority: urgent Blocks other ongoing work labels Mar 20, 2023
@pavish pavish added this to the v0.1.1 milestone Mar 20, 2023
@pavish pavish self-assigned this Mar 20, 2023
This was referenced Mar 20, 2023
Closed
Merged
@seancolsen seancolsen mentioned this issue Mar 21, 2023
Merged
7 tasks
@pavish
Copy link
Member Author

pavish commented Mar 21, 2023

Fixed by #2731

@pavish pavish closed this as completed Mar 21, 2023
@seancolsen seancolsen mentioned this issue Mar 23, 2023
Closed
AlekLefebvre pushed a commit to AlekLefebvre/mathesar that referenced this issue Apr 4, 2023
fix mathesar-foundation#2718
3f9eba0
@AlekLefebvre AlekLefebvre mentioned this issue Apr 20, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavish pavish

Labels
priority: urgent Blocks other ongoing work ready Ready for implementation restricted: maintainers Only maintainers can resolve this issue type: bug Something isn't working work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
[NO LONGER USED] Mathesar work tracker
Archived in project
Milestone
v0.1.1
Development

No branches or pull requests
1 participant
@pavish