Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell selection partially broken after selecting columns when table is filtered to be empty #2845

Open
seancolsen opened this issue Apr 25, 2023 · 0 comments · May be fixed by #3037
Open

Cell selection partially broken after selecting columns when table is filtered to be empty #2845

seancolsen opened this issue Apr 25, 2023 · 0 comments · May be fixed by #3037
Assignees
Labels
ready Ready for implementation restricted: maintainers Only maintainers can resolve this issue type: bug Something isn't working work: frontend Related to frontend code in the mathesar_ui directory
Milestone

Comments

@seancolsen
Copy link
Contributor

Steps to reproduce

  1. Begin with a table that has some rows in it.
  2. In the table inspector, enable the "Column" tab
  3. Add a filter condition like "id" = 0 which filters the table to be empty.
  4. Click a column header to select the column. (Also note that, due to Do not select columns when hovering column headers in a table with no rows #2130, hovering column headers also selects them.)
  5. Remove the filter condition, showing all rows.
  6. Select cells in various columns of the table. As you select cells, observe the highlighted stated of the column headers. Blue column headers indicate that the column is selected.
  7. Expect the selected columns to derived from the selected cells.
  8. Instead, observe that the column you selected while the table was empty is now stuck being selected regardless of which cells in the table are selected.
  9. If you filter the table to be empty again, you can change this "stuck" column, but you can't remove it.
  10. Refreshing the page resets the selection back to its know-good state.

@rajatvijay I want to put this on your radar since it relates to the cell selection code, which you've worked on more than anyone else.

@seancolsen seancolsen added ready Ready for implementation type: bug Something isn't working work: frontend Related to frontend code in the mathesar_ui directory restricted: maintainers Only maintainers can resolve this issue labels Apr 25, 2023
@seancolsen seancolsen added this to the Backlog milestone Apr 25, 2023
@rajatvijay rajatvijay self-assigned this Apr 25, 2023
@seancolsen seancolsen linked a pull request Jul 27, 2023 that will close this issue
7 tasks
@seancolsen seancolsen modified the milestones: Backlog, v0.1.4 Aug 17, 2023
@seancolsen seancolsen assigned seancolsen and unassigned rajatvijay Aug 17, 2023
@seancolsen seancolsen modified the milestones: v0.1.4, Backlog Oct 2, 2023
@kgodey kgodey modified the milestones: Backlog, v0.1.7 Apr 3, 2024
@ghislaineguerin ghislaineguerin modified the milestones: v0.1.7, High priority Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready for implementation restricted: maintainers Only maintainers can resolve this issue type: bug Something isn't working work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants