Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default value input steals focus when using keyboard to move active cell #2857

Closed
seancolsen opened this issue May 2, 2023 · 7 comments · Fixed by #2957
Closed

Default value input steals focus when using keyboard to move active cell #2857

seancolsen opened this issue May 2, 2023 · 7 comments · Fixed by #2957
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation type: bug Something isn't working work: frontend Related to frontend code in the mathesar_ui directory
Milestone
Backlog

Comments

@seancolsen
Copy link
Contributor

Steps to reproduce

  1. Go to to a table page with a Text column adjacent to a Number column.

  2. In the table inspector, select the "Table" tab.

  3. Select one cell within the Text column.

  4. Use the Right and Left arrow keys to move the active cell between the Text and Number columns. Observe that the active cell moves along with your key presses. Good!

  5. In the table inspector, select the "Column" tab.

  6. Using the mouse, select a cell in the Text column.

  7. Use the keyboard to move the active cell into the Number column. Observe that it moves. Good!

  8. Also observe that the Number input within the "Default Value" setting is focused. Not good!

    image

  9. Press the keyboard arrow keys, expecting the active cell to move with your key presses. Observe that the active cell does not move because it is no longer focused.

Fix

  • We should figure out what logic is causing that input to auto-focus and remove it.
@seancolsen seancolsen added ready Ready for implementation type: bug Something isn't working work: frontend Related to frontend code in the mathesar_ui directory labels May 2, 2023
@seancolsen seancolsen added this to the Backlog milestone May 2, 2023
@seancolsen seancolsen added good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this labels May 2, 2023
@dauinh
Copy link
Contributor

dauinh commented May 2, 2023

Hi! Can I work on this issue?

@seancolsen
Copy link
Contributor Author

Sure @dauinh. I've assigned you.

@seancolsen
Copy link
Contributor Author

@dauinh I've unassigned you from this issue due to inactivity. You're still welcome to submit a PR for it, but we'll leave it unassigned so that others may choose to work on it as well.

@nikhil-babar
Copy link

@seancolsen Can I work on this issue?

@seancolsen
Copy link
Contributor Author

Sure @nikhil-babar, go ahead

@seancolsen
Copy link
Contributor Author

Unassigned due to inactivity

@savita-kumari13 savita-kumari13 mentioned this issue Jun 17, 2023
Closed
5 tasks
@savita-kumari13
Copy link

Hey @seancolsen created a PR for this issue - #2951.
Let me know of any issues

@seancolsen seancolsen mentioned this issue Jun 20, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation type: bug Something isn't working work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
[NO LONGER USED] Mathesar work tracker
Archived in project
Milestone
Backlog
4 participants
@seancolsen @savita-kumari13 @dauinh @nikhil-babar