Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue:2857 - added focusOnMount={false} to prevent input's value getting focused in the "Column" tab #2951

Conversation

savita-kumari13
Copy link

…n the "Column" tab

autofocus.mov

Fixes #2857

Technical details

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@seancolsen
Copy link
Contributor

Thanks for this PR, @savita-kumari13. I tested your fix and found that it worked. But I didn't like the approach. The default behavior of inputs like this should be to not auto-focus.

In the process of investigating this problem, I opened #2957 with a fix made at a lower level to remove the auto-focus behavior. Then I implemented auto-focus behavior for the filtering UI to override that default, which is (as far as I can tell) the only place in the app where we actually want auto-focus.

Sorry to close this PR. We welcome more PRs!

@seancolsen seancolsen closed this Jun 20, 2023
@savita-kumari13 savita-kumari13 deleted the savita-kumari/issue-2857 branch June 21, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Default value input steals focus when using keyboard to move active cell
3 participants