Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General styling updates #473

Closed
4 of 10 tasks
kgodey opened this issue Jul 22, 2021 · 4 comments
Closed
4 of 10 tasks

General styling updates #473

kgodey opened this issue Jul 22, 2021 · 4 comments
Assignees
Labels
type: enhancement New feature or request
Milestone

Comments

@kgodey
Copy link
Contributor

kgodey commented Jul 22, 2021

Problem

Currently, we've been focusing Mathesar design work on functionality and user interactions. The visual style is pretty basic and should be improved.

Proposed solution

We should update the design that we have for Mathesar so far with improved visual styles. There aren't a lot of hard requirements, and this issue involves taking some time to focus on how Mathesar looks.

The solution requires the following aspects of the UI to be defined:

  • The different themeable attributes that can be modified for the theme (e.g., background color, table borders)
  • UI layout definitions: Define how the structure that supports the interface components should be styled and how they should behave in different states and resolutions (e.g., visible, hidden, minimized)
  • UI component definitions: Define how the various interactive components should look like and behave in different states (e.g., empty, active, error)

Additional context

  • More color and contrast would be great!
  • We should design Mathesar to be theme-able in the future so that people can change the colors for a different look.

Components to style

  • Top navigation
  • Table and Table Toolbar
  • Schema and Database Pages
  • Data Explorer
  • Record Page
  • Data Import
  • Table Inspector
  • Icons and Buttons
  • Actions Pane
  • Record Selector
@kgodey kgodey added type: enhancement New feature or request work: design ready Ready for implementation labels Jul 22, 2021
@kgodey kgodey added this to the 2021-08 improvements milestone Jul 22, 2021
@kgodey kgodey added needs: unblocking Blocked by other work and removed ready Ready for implementation labels Jul 22, 2021
@kgodey
Copy link
Contributor Author

kgodey commented Jul 22, 2021

We plan to do this after the design for the 11. User Management milestone, so marking as blocked until then.

@kgodey kgodey mentioned this issue Jul 22, 2021
7 tasks
@kgodey kgodey modified the milestones: 2021-09 improvements, 06. 2021-09 Stability Aug 31, 2021
@kgodey kgodey added status: draft and removed needs: unblocking Blocked by other work labels Sep 7, 2021
@ghislaineguerin
Copy link
Contributor

@kgodey, I've added the list of placeholder issues that we will need to address to complete the app's styling. Please let me know if it makes sense.

@kgodey
Copy link
Contributor Author

kgodey commented Oct 14, 2021

@ghislaineguerin I assume each of these is for redesigning that particular element. It looks good to me. I assume we'll also be making further changes once we add new features.

Things that I don't see here (but may be covered in other items that I'm not noticing):

  • Theme design (picking colors for themes)
  • Modals (e.g. the table constraints modal)
  • The table import confirmation page
  • Data type specific styling (e.g. datepicker, tabular figures)
  • Picking fonts

Do you want to turn this into a meta-issue and create sub-issues for each of the issues so you can tackle them one at a time?

@kgodey kgodey modified the milestones: [06] 2021-10 Stability, [06A] 2021-10 improvements Oct 14, 2021
@kgodey kgodey modified the milestones: [08.1] 2022-01 improvements, [10] UI Styling Dec 13, 2021
@kgodey kgodey modified the milestones: [10] UI Styling, Cycle 2 Jun 1, 2022
@kgodey kgodey modified the milestones: Cycle 2, Cycle 3 Jul 19, 2022
@kgodey
Copy link
Contributor Author

kgodey commented Sep 14, 2022

I'm going to close this issue since we're covering this the various "demo readiness" issues like #1604.

@kgodey kgodey closed this as completed Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

2 participants