Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend work for adding multi-column unique constraints #531

Closed
kgodey opened this issue Aug 9, 2021 · 3 comments · Fixed by #1005
Closed

Frontend work for adding multi-column unique constraints #531

kgodey opened this issue Aug 9, 2021 · 3 comments · Fixed by #1005
Assignees
Labels
type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory

Comments

@kgodey
Copy link
Contributor

kgodey commented Aug 9, 2021

Problem

Users may want to create unique constraints on tables.

Proposed solution

We should provide a way to create unique constraints from the UI following the "Working with Columns" design spec.

This covers allowing the addition of a new unique constraint, including auto-complete for column names.

Adding other types of constraints will not yet be supported.

Additional context

@kgodey kgodey added type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory needs: unblocking Blocked by other work labels Aug 9, 2021
@kgodey kgodey added this to the 06. Working with Tables milestone Aug 9, 2021
@github-actions
Copy link

github-actions bot commented Nov 7, 2021

This issue has not been updated in 90 days and is being marked as stale.

@github-actions github-actions bot added the stale label Nov 7, 2021
@kgodey kgodey added ready Ready for implementation and removed stale needs: unblocking Blocked by other work labels Nov 8, 2021
@kgodey
Copy link
Contributor Author

kgodey commented Nov 8, 2021

This is ready for work now that #328 is done.

@pavish pavish self-assigned this Nov 12, 2021
@seancolsen seancolsen assigned seancolsen and unassigned pavish Dec 8, 2021
@seancolsen seancolsen added status: started and removed ready Ready for implementation labels Dec 8, 2021
@seancolsen
Copy link
Contributor

@ghislaineguerin and I chatted about the design for this and agreed on the following:

  • Build on the current Table Constraints modal.
  • Insert an "Add" button above the list of constraints.
  • When you click "Add", the whole contents of the modal slide to the left and are replaced by a form to add a new table constraint.
    • The form has "Cancel" and "Save" buttons at the bottom.
    • If you click "Cancel", the modal slides back to view the list of constraints.
    • If you fill out the form and click "Add", the modal slides back to view the list of constraints and the newly-added constraint is briefly highlighted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants