Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor db code to work with existing connections #592

Closed
kgodey opened this issue Aug 21, 2021 · 2 comments
Closed

Refactor db code to work with existing connections #592

kgodey opened this issue Aug 21, 2021 · 2 comments
Labels
affects: architecture Improvements or additions to architecture affects: technical debt Improves the state of the codebase ready Ready for implementation restricted: maintainers Only maintainers can resolve this issue type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL
Milestone

Comments

@kgodey
Copy link
Contributor

kgodey commented Aug 21, 2021

Problem

In #578, we updated some of the code in the db module to use existing connections so that we could perform multiple operations in a single transaction. This was done in an ad-hoc basis and isn't easy to read or extend.

Proposed solution

We should figure out an idiomatic and clear way to pass connections and tables around between functions and refactor the code accordingly.

This code should also involve refactoring all the code in db/columns.py to use connections so that:

  • code for batch altering and altering a single column can be consolidated
  • all code for duplicating a column happens in a single connection

Additional context

@kgodey kgodey added type: enhancement New feature or request affects: technical debt Improves the state of the codebase work: database ready Ready for implementation restricted: maintainers Only maintainers can resolve this issue labels Aug 21, 2021
@kgodey kgodey added this to the 2021-09 improvements milestone Aug 21, 2021
@kgodey kgodey added the affects: architecture Improvements or additions to architecture label Aug 22, 2021
@kgodey kgodey modified the milestones: 2021-09 improvements, 06. 2021-09 Stability Aug 31, 2021
@kgodey kgodey self-assigned this Aug 31, 2021
@kgodey kgodey added status: started and removed ready Ready for implementation labels Oct 14, 2021
@kgodey kgodey modified the milestones: [06] 2021-10 Stability, [06A] 2021-10 improvements Oct 14, 2021
@kgodey kgodey added ready Ready for implementation and removed status: started labels Oct 19, 2021
@kgodey kgodey removed their assignment Oct 19, 2021
@kgodey kgodey modified the milestones: [06.2] 2022-04 improvements, [08.1] 2022-05 improvements May 2, 2022
@github-actions
Copy link

This issue has not been updated in 90 days and is being marked as stale.

@github-actions github-actions bot added the stale label Jul 17, 2023
@rajatvijay rajatvijay removed the stale label Jul 18, 2023
@seancolsen seancolsen added work: backend Related to Python, Django, and simple SQL and removed work: database labels Dec 5, 2023
@kgodey
Copy link
Contributor Author

kgodey commented Feb 2, 2024

Closing this, too old, requirements are out of date. We can create a new issue if we need this functionality in the future.

@kgodey kgodey closed this as not planned Won't fix, can't repro, duplicate, stale Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: architecture Improvements or additions to architecture affects: technical debt Improves the state of the codebase ready Ready for implementation restricted: maintainers Only maintainers can resolve this issue type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL
Projects
No open projects
Development

No branches or pull requests

3 participants