Wait until user is done editing a cell before saving

[seancolsen]

Current behavior

1. Double click a cell to enter edit mode.
2. Modify the value by typing something new.
3. Wait 1 second.
4. Expect nothing.
5. Observe the value of the cell is saved.
6. Press Esc.
7. Mode changes from edit to select.
8. Expect the cell value to be its original value before edits began, because I pressed Esc.
9. Observe the cell value to be changed.

Proposed behavior

• Follow the same UX that spreadsheets use. LibreOffice Calc and Google Sheets both behave as follows... The cell value does not get saved until you leave edit mode with one of the following options:

  • Enter
  • Shift+Enter
  • Tab
  • Shift+Tab
  • a click outside the cell

Notes

• I think this is relevant to our recent discussion about data integrity during editing. If our users expect the same behavior that I expect, then they might be annoyed that pressing Esc did not "undo" (so-to-speak) the edits they made to a cell.

[kgodey]

This sounds good to me.

[seancolsen]

Thanks @kgodey. I'm marking this as ready now that we have support from one other person.

@ghislaineguerin @pavish you two might still like to weigh in if you have any concerns here.

[seancolsen]

#1080 seems to have fixed this, so I'm closing it.

@pavish I noticed you marked that PR as "related to" this issue instead of "fixes" this issue. Is that just because of the difference in behavior with regard to the Esc key? (If so, I'm planning to open a separate issue for that where we can discuss it.)

[pavish]

@seancolsen Yes, I left it open to discuss the behaviour of esc key. I'm fine with opening a separate issue for it.