Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blur via keyboard after entering edit mode on a NULL cell should cancel edits #929

Closed
seancolsen opened this issue Jan 3, 2022 · 2 comments
Closed

Blur via keyboard after entering edit mode on a NULL cell should cancel edits #929

seancolsen opened this issue Jan 3, 2022 · 2 comments
Labels
affects: ux Related to user experience good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Milestone
[07] Initial Data...

Comments

@seancolsen
Copy link
Contributor

seancolsen commented Jan 3, 2022 •
edited
Loading

Reproduce

  1. Double click a NULL cell to enter edit mode.
  2. Press Esc or Tab or Enter.
  3. Observe the mode changing from edit to select.
  4. Expect cell value to remain NULL.
  5. Observe cell value is set to an empty string.

The expected behavior is described in NULL Value Specs, scenario 2d.
@seancolsen seancolsen added ready Ready for implementation good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory affects: ux Related to user experience labels Jan 3, 2022
@seancolsen seancolsen added this to the [06] Working with Tables milestone Jan 3, 2022
@pavish pavish modified the milestones: [06] Working with Tables, [Beta] Better Editing Experience, [07.1] 2022-01 improvements Jan 3, 2022
@seancolsen seancolsen mentioned this issue Jan 3, 2022
Closed
@seancolsen seancolsen changed the title Esc key after entering edit mode on a NULL cell should cancel edits Blur after entering edit mode on a NULL cell should cancel edits Jan 31, 2022
@seancolsen seancolsen changed the title Blur after entering edit mode on a NULL cell should cancel edits Blur via keyboard after entering edit mode on a NULL cell should cancel edits Jan 31, 2022
@aviwad
Copy link

aviwad commented Mar 22, 2022

Hello! Could I get assigned to this? Sounds interesting. I think i can fix this.

Would you know which functions are run when a cell is selected / deselected? that would help me check why NULL value is overwritten with empty string.

@pavish
Copy link
Member

pavish commented Mar 22, 2022

Hi @aviwad, this behavior was modified in several PRs after this issue was raised, rendering this issue void. Sorry that we did not check and close this earlier.

As a followup, there are couple issues which were raised:

@pavish pavish closed this as completed Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects: ux Related to user experience good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
[NO LONGER USED] Mathesar work tracker
Archived in project
Milestone
[07] Initial Data Types
Development

No branches or pull requests
3 participants
@seancolsen @pavish @aviwad