Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display NULL while editing a NULL cell #939

Closed
seancolsen opened this issue Jan 3, 2022 · 3 comments · Fixed by #961
Closed

Display NULL while editing a NULL cell #939

seancolsen opened this issue Jan 3, 2022 · 3 comments · Fixed by #961
Assignees
Labels
affects: ux Related to user experience good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory

Comments

@seancolsen
Copy link
Contributor

seancolsen commented Jan 3, 2022

Current behavior

  1. Find a NULL cell.
  2. Double click to enter edit mode.
  3. Observe that NULL no longer displays when in edit mode, leaving the user with no way to distinguish NULL from empty string while editing.

Desired behavior

  1. Double click to enter edit mode on a NULL cell.
  2. NULL appears after the cursor, styled the same as when viewing the cell in select mode.
  3. Begin entering text.
  4. Observe that NULL disappears, being replaced by the text entered.
  5. Delete all text entered.
  6. Observe the cell to be blank (no NULL displayed) indicating the value is an empty string.

Notes

See also

Additional context

See NULL Value Specs, scenario 2b

@seancolsen seancolsen added type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory affects: ux Related to user experience ready Ready for implementation good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this labels Jan 3, 2022
@seancolsen seancolsen added this to the [07] Initial Data Types milestone Jan 3, 2022
@gagan2005
Copy link
Contributor

I would like to work on this

@seancolsen
Copy link
Contributor Author

Thanks @gagan2005! I've assigned this ticket to you. Let us know if you need any help. Feel free to ask questions here or in Matrix (our chat system).

@seancolsen seancolsen added status: started and removed ready Ready for implementation labels Jan 6, 2022
@gagan2005
Copy link
Contributor

#961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: ux Related to user experience good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants