Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign import preview UX #934

Closed
pavish opened this issue Jan 3, 2022 · 5 comments · Fixed by #1628
Closed

Redesign import preview UX #934

pavish opened this issue Jan 3, 2022 · 5 comments · Fixed by #1628
Assignees
Labels
type: bug Something isn't working
Milestone

Comments

@pavish
Copy link
Member

pavish commented Jan 3, 2022

Our import preview UX doesn't match the rest of the application, since it was one of the first pages designed. We should update it. Some specific problems and related issues/discussions are listed below.

Column type selection in preview page varies entirely with the type selection on the table

Description

Upon file upload, the preview page displays a list of database types.

Screenshot 2022-01-03 at 11 49 12 AM

In our table, we display the mathesar types and we do not allow directly setting the database type

Screenshot 2022-01-03 at 12 00 41 PM

Expected behavior

We should have similar UX in both these places since it may confuse users otherwise. However, we might want to only show few configuration options in the preview page.

Related discussions

@pavish pavish added type: bug Something isn't working work: design labels Jan 3, 2022
@pavish pavish added this to the [07.1] 2022-01 improvements milestone Jan 3, 2022
@pavish
Copy link
Member Author

pavish commented Jan 3, 2022

@kgodey @ghislaineguerin Marking this issue as draft until both of you could take a look and add any additional detail if required.

@kgodey kgodey modified the milestones: [07.1] 2022-01 improvements, [09] UI Styling Jan 3, 2022
@kgodey
Copy link
Contributor

kgodey commented Jan 3, 2022

This is because we designed the import preview page way before we figured out data types. I think we should address this in the UI Styling milestone since that's where we'll be making sure what we've built is consistently styled (I've moved it there).

@pavish pavish added ready Ready for implementation and removed status: draft labels Jan 3, 2022
@kgodey kgodey added status: draft and removed ready Ready for implementation labels Mar 5, 2022
@kgodey
Copy link
Contributor

kgodey commented Mar 5, 2022

We need an updated design for this, so marking as draft.

@kgodey kgodey changed the title Column type selection in preview page varies entirely with the type selection on the table Redesign import preview UX Mar 29, 2022
@vrutik2809
Copy link
Contributor

While importing the data, one file named <file_name>_<id>.csv is created in .media directory.
So, when the user cancels the import then it would be better to delete that file from the directory to utilize the space efficiently.

@kgodey
Copy link
Contributor

kgodey commented Sep 12, 2022

Assigning this to @pavish to close since he's implementing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants