Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use record selector when editing cells in FK columns #954

Closed
seancolsen opened this issue Jan 5, 2022 · 4 comments
Closed

Use record selector when editing cells in FK columns #954

seancolsen opened this issue Jan 5, 2022 · 4 comments
Assignees
Labels
type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Milestone

Comments

@seancolsen
Copy link
Contributor

Current behavior

  • Editing a cell within a FK column requires the user to know the value of the target column which is usually a meaningless id number. This makes it tedious for users to link records.

Desired behavior

  • Editing a cell within a FK column will open a record selector, allowing the user to search and select a record from the target table.

Specs

Status

@seancolsen seancolsen added needs: unblocking Blocked by other work type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory labels Jan 5, 2022
@seancolsen seancolsen added this to the [08] Working with Views milestone Jan 5, 2022
@seancolsen
Copy link
Contributor Author

@ghislaineguerin @kgodey The specs read:

in the case of multi-column foreign key constraints, the system could modify additional fields.

I don't think we should enable the record selector for multi-column FKs. Is that okay? If it becomes a problem we could address it as-needed.

@kgodey
Copy link
Contributor

kgodey commented Jan 10, 2022

I don't think we should enable the record selector for multi-column FKs. Is that okay? If it becomes a problem we could address it as-needed.

Agreed, I don't think there should be any special behavior for multi-column FKs, it should be treated as a text field. @ghislaineguerin Can you remove the part that Sean quoted in the spec to avoid confusion?

@ghislaineguerin
Copy link
Contributor

@kgodey I agree, we should just treat it as text input. I'll update the spec.

@kgodey kgodey modified the milestones: [09] Working with Views, [08] Links Between Tables Jan 18, 2022
@seancolsen seancolsen self-assigned this Apr 20, 2022
@kgodey kgodey modified the milestones: [08] Links between Tables, Cycle 2 Jun 1, 2022
@kgodey kgodey modified the milestones: Cycle 2, Cycle 3 Jul 19, 2022
@seancolsen seancolsen removed the needs: unblocking Blocked by other work label Jul 27, 2022
@seancolsen
Copy link
Contributor Author

This work was started in #1445. Subsequent polish work will be tracked in more detailed tickets as-needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
Development

No branches or pull requests

3 participants