Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front end support for configuring table settings #955

Closed
seancolsen opened this issue Jan 5, 2022 · 2 comments
Closed

Front end support for configuring table settings #955

seancolsen opened this issue Jan 5, 2022 · 2 comments
Assignees
Labels
needs: unblocking Blocked by other work type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Milestone

Comments

@seancolsen
Copy link
Contributor

Current behavior

  • User has no way to configure the behavior of the record previews (within foreign key columns) and record selector (while editing data in foreign key columns).

Desired behavior

  • The Foreign Key Constraints Spec briefly talks about "Table Link Preferences" in the video for Scenario 5.
  • Some details of the data storage are still TBD in API support for storing "record preview" and "record selector" settings #944. When that ticket is done, we should add the UI to view and update those settings.
  • We'll most likely want a modal dialog to configure the settings.
  • Entry points to open the modal, as shown in the specs and prototype:
    • Within the record selector for a cell in a FK column
    • Within the column header menu of a FK column
  • There's some nuance to how we set up this dialog though. If table X is referencing table Y, then we need to open the Y settings when viewing X. If we add other table-level settings later on then we might not want those table-level settings for table Y to display from an entry point in table X. I think it might be best to have a component that displays the "table link" settings. From table X we open a modal that displays only the "table link" settings from table Y. From table Y, we can also open a "Table Settings" modal which displays all table settings for table Y and includes the component which displays the "table link" settings.

Questions to answer

  • If, in API support for storing "record preview" and "record selector" settings #944, we decide to store the record preview toggle state at the table level, then do we still want to allow the user to toggle the record preview from column header menu, even though it would affect other columns too? I think we probably do.
  • Do we want to provide an additional entry point to open the settings modal from the target table? If so, I think we'd add a "Settings" menu item.

Status

@seancolsen seancolsen added needs: unblocking Blocked by other work type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory labels Jan 5, 2022
@seancolsen seancolsen added this to the [08] Working with Views milestone Jan 5, 2022
@kgodey
Copy link
Contributor

kgodey commented Jan 10, 2022

If, in API support for storing table-level settings #944, we decide to store the record preview toggle state at the table level, then do we still want to allow the user to toggle the record preview from column header menu, even though it would affect other columns too? I think we probably do.

Yes, we're assuming the user will be likely to want to change them at the column level while searching.

@kgodey kgodey modified the milestones: [09] Working with Views, [08] Links Between Tables Jan 18, 2022
@seancolsen seancolsen self-assigned this Apr 20, 2022
@kgodey kgodey modified the milestones: [08] Links between Tables, Cycle 2 Jun 1, 2022
@kgodey kgodey modified the milestones: Cycle 2, Cycle 3 Jul 19, 2022
@seancolsen
Copy link
Contributor Author

I'm closing this ticket because, as spec'ed, it is now so out-of-date with our current design that it no longer seems useful. "Record Summary" and "Record Selector" actually mean different things now! The product goal that this ticket intended to address will now be addressed by the "Summary Expression Builder" within Record Summary feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: unblocking Blocked by other work type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
Development

No branches or pull requests

2 participants