-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move column dropping to DB functions #2743
Conversation
Unassigning myself as @dmos62 has already reviewed the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the naming changes!
- Remove the namespace (schema), | ||
- Replace any white space in the type name with underscores, | ||
- Replace double quotes in the type name (e.g., the "char" type) with '_double_quote_' | ||
- Use the prepped type name in the name `mathesar_types.cast_to_%s`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciated 👍
@@ -28,6 +28,27 @@ well as its name identifer(s). | |||
|
|||
Note that these identification schemes apply to the public-facing functions in the `msar` namespace, | |||
not necessarily the internal `__msar` functions. | |||
|
|||
NAMING CONVENTIONS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming looks great!
Related to #2737
db.columns.operations.drop
db.columns.operations.alter.batch_alter_table_drop_columns
psycopg2_conn
function execution wrapper.Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin