Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move column dropping to DB functions #2743

Merged
merged 20 commits into from
Apr 20, 2023
Merged

Move column dropping to DB functions #2743

merged 20 commits into from
Apr 20, 2023

Conversation

mathemancer
Copy link
Contributor

@mathemancer mathemancer commented Mar 24, 2023

Related to #2737

  • Removes SQLAlchemy from db.columns.operations.drop
  • Removes SQLAlchemy from db.columns.operations.alter.batch_alter_table_drop_columns
  • Fixes a bug in the psycopg2_conn function execution wrapper.
  • On top of functions added to support the above, adds a DB function to get the correct casting function name from any type.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@mathemancer mathemancer changed the title Split move merge sql Move column dropping to DB functions Mar 24, 2023
@mathemancer mathemancer marked this pull request as ready for review March 24, 2023 07:37
@mathemancer mathemancer requested a review from dmos62 March 24, 2023 07:37
@mathemancer mathemancer added the pr-status: review A PR awaiting review label Mar 24, 2023
@rajatvijay rajatvijay added this to the Backlog milestone Mar 24, 2023
@mathemancer mathemancer requested review from Anish9901 and removed request for dmos62 April 13, 2023 13:25
@mathemancer mathemancer assigned Anish9901 and unassigned dmos62 Apr 13, 2023
@mathemancer mathemancer requested a review from dmos62 April 13, 2023 13:25
db/sql/0_msar.sql Show resolved Hide resolved
db/sql/0_msar.sql Show resolved Hide resolved
db/sql/0_msar.sql Outdated Show resolved Hide resolved
db/columns/operations/alter.py Outdated Show resolved Hide resolved
db/tables/operations/alter.py Show resolved Hide resolved
db/types/operations/cast.py Show resolved Hide resolved
@dmos62 dmos62 added pr-status: revision A PR awaiting follow-up work from its author after review and removed pr-status: review A PR awaiting review labels Apr 14, 2023
@mathemancer mathemancer requested a review from dmos62 April 18, 2023 14:04
@mathemancer mathemancer added pr-status: review A PR awaiting review and removed pr-status: revision A PR awaiting follow-up work from its author after review labels Apr 18, 2023
@Anish9901
Copy link
Member

Unassigning myself as @dmos62 has already reviewed the PR.

@Anish9901 Anish9901 removed their request for review April 19, 2023 13:38
@Anish9901 Anish9901 assigned dmos62 and unassigned Anish9901 Apr 19, 2023
Copy link
Contributor

@dmos62 dmos62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the naming changes!

- Remove the namespace (schema),
- Replace any white space in the type name with underscores,
- Replace double quotes in the type name (e.g., the "char" type) with '_double_quote_'
- Use the prepped type name in the name `mathesar_types.cast_to_%s`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciated 👍

@@ -28,6 +28,27 @@ well as its name identifer(s).

Note that these identification schemes apply to the public-facing functions in the `msar` namespace,
not necessarily the internal `__msar` functions.

NAMING CONVENTIONS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming looks great!

@dmos62 dmos62 added this pull request to the merge queue Apr 20, 2023
Merged via the queue into develop with commit beefd23 Apr 20, 2023
@dmos62 dmos62 deleted the split_move_merge_sql branch April 20, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants