Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icon in exploration editor breadcrumb #2757

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Update icon in exploration editor breadcrumb #2757

merged 2 commits into from
Mar 27, 2023

Conversation

thesujai
Copy link
Contributor

Fixes #2688:Update icon in exploration editor breadcrumb

Technical details

In routes/DataExplorerRoute.svelte the AppendBreadcrumb component with Edit label was having icon component set to iconExploration. So when we were fetching the icon for the edit component with item.icon we were getting the exploration icon.
Changing the icon component to iconEdit(by importing from @mathesar/icons), we can expect the desired behavior.

Screenshots
Before:
Screenshot from 2023-03-16 02-29-43

After:
Screenshot from 2023-03-16 02-30-35

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@thesujai
Copy link
Contributor Author

@rajatvijay i mistakely closed #2692.
please review this one

@pavish pavish self-assigned this Mar 27, 2023
@pavish pavish added the pr-status: review A PR awaiting review label Mar 27, 2023
@pavish pavish added this pull request to the merge queue Mar 27, 2023
Merged via the queue into mathesar-foundation:develop with commit 65b9111 Mar 27, 2023
@thesujai thesujai deleted the edit-icon-change branch July 1, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Update icon in exploration editor breadcrumb
2 participants