Update icon in exploration editor breadcrumb #2757
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2688:Update icon in exploration editor breadcrumb
Technical details
In
routes/DataExplorerRoute.svelte
theAppendBreadcrumb
component withEdit
label was having icon component set toiconExploration
. So when we were fetching the icon for the edit component withitem.icon
we were getting the exploration icon.Changing the icon component to
iconEdit
(by importing from@mathesar/icons
), we can expect the desired behavior.Screenshots
Before:
After:
Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin