Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cell tab in table inspector for showing cell content #2778

Conversation

raunak-dev-edu
Copy link
Contributor

Fixes #2342

This Pull request will add a cell tab in the table inspector in the table page that will show cell content similar to the inspector in Exploration Page.

Screenshots

Like this -

image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@rajatvijay rajatvijay added this to the Backlog milestone Apr 5, 2023
@rajatvijay rajatvijay self-requested a review April 5, 2023 15:22
@rajatvijay rajatvijay self-assigned this Apr 5, 2023
@rajatvijay rajatvijay added the pr-status: review A PR awaiting review label Apr 5, 2023
dmos62
dmos62 previously requested changes Apr 11, 2023
Copy link
Contributor

@dmos62 dmos62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fix the lint and format check failures.

Also, you've based this on an abandoned PR and implemented the changes requested in that PR: #2385

This is the second PR you're basing off of someone else's work, without saying that. As I said on the other PR, that looks pretty bad.

@dmos62 dmos62 added pr-status: revision A PR awaiting follow-up work from its author after review and removed pr-status: review A PR awaiting review labels Apr 11, 2023
@dmos62 dmos62 removed the request for review from rajatvijay April 11, 2023 12:50
@dmos62 dmos62 assigned raunak-dev-edu and unassigned rajatvijay Apr 11, 2023
@raunak-dev-edu
Copy link
Contributor Author

Please, fix the lint and format check failures.

Also, you've based this on an abandoned PR and implemented the changes requested in that PR: #2385

This is the second PR you're basing off of someone else's work, without saying that. As I said on the other PR, that looks pretty bad.

I'd like to apologize once again. I raised my PR after thoroughly reviewing #2385 and discovering that there had been no response to the suggested review. My intention was to help resolve the issue as quickly as possible. However, I realize that I made a mistake by not referencing the PRs and failing to comment on this matter when I submitted my own PR. I'm truly sorry for any confusion or inconvenience caused by my oversight.

@rajatvijay
Copy link
Contributor

@dmos62 I am going to start the review on this since the lint checks are now passing.

@rajatvijay rajatvijay self-requested a review April 18, 2023 15:33
@rajatvijay rajatvijay added pr-status: review A PR awaiting review and removed pr-status: revision A PR awaiting follow-up work from its author after review labels Apr 18, 2023
@github-actions
Copy link

This pull request has not been updated in 45 days and is being marked as stale. It will automatically be closed in 30 days if not updated by then.

@github-actions
Copy link

This pull request has not been updated in 45 days and is being marked as stale. It will automatically be closed in 30 days if not updated by then.

@github-actions github-actions bot added the stale label Aug 25, 2023
@rajatvijay rajatvijay removed the stale label Sep 11, 2023
@seancolsen seancolsen assigned seancolsen and unassigned rajatvijay Nov 1, 2023
Copy link
Contributor

@seancolsen seancolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @raunak-dev-edu. I added a few commits to clean up some small things.

@seancolsen seancolsen dismissed dmos62’s stale review November 6, 2023 20:26

Overriding Dom's review

@seancolsen seancolsen added this pull request to the merge queue Nov 6, 2023
Merged via the queue into mathesar-foundation:develop with commit c73ac65 Nov 6, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Show cell content in table inspector Cell tab
4 participants