New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Showed both row and column level context menu options in the cell level #2728 #2803
Conversation
@TafreedAhmad Make sure to fix formatting, and linting issues before marking the PR for review again. |
…it's type is number in RowContextOptions.svelte file
@pavish You may check it now, I was just making my new branch equal to the old branch in the previous commit because my last fork was corrupted somehow so I had to re-fork and re-build it. |
@pavish It's done using props this time... |
@TafreedAhmad the lint checks are still failing. |
@rajatvijay I've updated it but the lint checks aren't running now |
@pavish I am unable to run lint tests locally due to some errors but I have removed them and have formatted the document several times and it is still giving me errors... |
@TafreedAhmad The errors on the workflow seem to be due to formatting issues. You can run You can then fix the errors manually or automatically using: You can refer Prettier docs to better understand how formatting using Prettier works. Refer our frontend readme file to understand how to perform formatting, linting, and testing. |
@pavish Thanks a lot. I was really struggling to find the error here... I think it's done now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TafreedAhmad Looks good! Thanks for your work on this.
I've added a few commits to clear things up:
- 4e1af61 This commit directly passes down
rowKey
instead of theprimaryKeyColumnId
since we already calculate it in the parent component. It also removes the unnecessaryString(rowKey)
case, sincerowKey
is explicitly a string type. - 9b78059 This moves the 'Go To Linked Record' options to it's appropriate section, the cell level options section.
- 06a69c8 This renames
recordId
torecordPk
inRowContextOptions
to better improve readability of the purpose of the prop.
795a629
I opened #2846 as a small follow-up to this. |
Fixes #2702
Technical details
The options that were previously available only in the row-level and column-level menus are now also present in the cell-level menu, and I have implemented their functionality to match that of the row-level and column-level menus.
Screenshots
Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin