Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Django REST Framework settings to use JSONParser as the default parser for incoming requests #3090

Merged
merged 11 commits into from Nov 16, 2023

Conversation

varshadr
Copy link
Contributor

Fixes #3089

This PR removes unnecessary application/x-www-form-urlencoded and multipart/form-data content types from the requestBody section in relevant API endpoints, by updating the Django REST Framework settings to use JSONParser as the default parser for incoming requests.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@varshadr varshadr added type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL pr-status: review A PR awaiting review labels Jul 24, 2023
@varshadr varshadr added this to the GSoC 2023 milestone Jul 24, 2023
@varshadr varshadr linked an issue Jul 24, 2023 that may be closed by this pull request
Copy link
Contributor

@silentninja silentninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@varshadr varshadr changed the title Updated Django REST Framework settings to use JSONParser as the defau… Updated Django REST Framework settings to use JSONParser as the default parser for incoming requests Aug 21, 2023
Copy link
Contributor

@silentninja silentninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test cases are failing. This is happening because uploading /datafiles/ API relies on the multipart/form-data. So you would need to add additional multipart/form-data parser support for the /datafiles/API. Please request a review once the test cases are passing

@silentninja silentninja assigned varshadr and unassigned silentninja Aug 22, 2023
@silentninja silentninja added pr-status: revision A PR awaiting follow-up work from its author after review and removed pr-status: review A PR awaiting review labels Aug 22, 2023
@varshadr
Copy link
Contributor Author

The test cases are failing. This is happening because uploading /datafiles/ API relies on the multipart/form-data. So you would need to add additional multipart/form-data parser support for the /datafiles/API. Please request a review once the test cases are passing

Sure, I'll check

@varshadr varshadr assigned mathemancer and unassigned varshadr Nov 4, 2023
@varshadr varshadr added pr-status: review A PR awaiting review and removed pr-status: revision A PR awaiting follow-up work from its author after review labels Nov 4, 2023
@seancolsen
Copy link
Contributor

@varshadr I'm re-assigning this to @mathemancer because Mukesh will no longer be working with you on this project. Please assign any further PRs to @mathemancer for review.

@varshadr
Copy link
Contributor Author

varshadr commented Nov 8, 2023

@varshadr I'm re-assigning this to @mathemancer because Mukesh will no longer be working with you on this project. Please assign any further PRs to @mathemancer for review.

Sure @seancolsen , I will

Copy link
Contributor

@mathemancer mathemancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice work, @varshadr !

@mathemancer mathemancer dismissed silentninja’s stale review November 16, 2023 06:47

It's obsolete, the changes have been made.

@mathemancer mathemancer added this pull request to the merge queue Nov 16, 2023
Merged via the queue into develop with commit de4eeef Nov 16, 2023
23 checks passed
@mathemancer mathemancer deleted the 3089-remove-redundant-request-body-content-types branch November 16, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Remove redundant Request body content types
5 participants