New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added excel normalization code and associated tests #3132
Added excel normalization code and associated tests #3132
Conversation
@dmos62 PTAL. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just a minor suggested change.
if all(df.columns.str.startswith('Unnamed')): | ||
df.columns = df.iloc[0] | ||
df = df[1:] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there should be a conderation here for whether or not the first row of the data is a header in #3030.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that is planned for the coming PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, this looks good to me, thanks for your work on this @IamEzio!
ca66cce
Fixes #2994
Related to #3027
This PR adds excel normalization code, that is, removes null rows and columns when reading the excel files.
Screenshots
excel-norm.mp4
Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin