Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable SQL tests broken by upstream bug #3156

Merged
merged 1 commit into from Aug 23, 2023
Merged

Disable SQL tests broken by upstream bug #3156

merged 1 commit into from Aug 23, 2023

Conversation

mathemancer
Copy link
Contributor

pgTAP 1.3.0 introduced a bug that affects our tests, but not the actual functionality of our SQL logic:
theory/pgtap#315

This PR should be reverted once that bug is sorted. I'll also jump in on the issue in the upstream repo.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

pgTAP 1.3.0 introduced a bug that affects our tests, but not
the actual functionality of our SQL logic:
theory/pgtap#315
Copy link
Contributor

@dmos62 dmos62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmos62 dmos62 added this pull request to the merge queue Aug 23, 2023
Merged via the queue into develop with commit 6d677c3 Aug 23, 2023
13 checks passed
@dmos62 dmos62 deleted the sql_test_bugskip branch August 23, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants