Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated oid and column_order fields to only allow positive integers #3177

Conversation

varshadr
Copy link
Contributor

@varshadr varshadr commented Aug 25, 2023

Fixes #3176

This PR addresses constraints for the oid field and the column_order field in the TableSettings object. Both fields currently allow negative integers. This update ensures that oid and column_order only accepts positive integers.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@varshadr varshadr added type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL work: database labels Aug 25, 2023
@varshadr varshadr added this to the GSoC 2023 milestone Aug 25, 2023
@varshadr varshadr linked an issue Aug 25, 2023 that may be closed by this pull request
@github-actions

This comment was marked as outdated.

Copy link
Contributor

@silentninja silentninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@varshadr Please run makemigrations to generate the migration file for converting the existing database columns and add it to the PR.

@silentninja silentninja assigned varshadr and unassigned silentninja Oct 31, 2023
@silentninja silentninja added the pr-status: revision A PR awaiting follow-up work from its author after review label Oct 31, 2023
@varshadr
Copy link
Contributor Author

varshadr commented Nov 3, 2023

@varshadr Please run makemigrations to generate the migration file for converting the existing database columns and add it to the PR.

Okay 👍

@varshadr varshadr added pr-status: review A PR awaiting review and removed pr-status: revision A PR awaiting follow-up work from its author after review labels Nov 4, 2023
@varshadr varshadr removed their assignment Nov 4, 2023
@seancolsen seancolsen assigned mathemancer and unassigned silentninja Nov 7, 2023
@seancolsen
Copy link
Contributor

@varshadr I'm re-assigning this to @mathemancer because Mukesh will no longer be working with you on this project. Please assign any further PRs to @mathemancer for review.

@varshadr
Copy link
Contributor Author

varshadr commented Nov 8, 2023

@varshadr I'm re-assigning this to @mathemancer because Mukesh will no longer be working with you on this project. Please assign any further PRs to @mathemancer for review.

Sure 👍

@varshadr varshadr added pr-status: review A PR awaiting review and removed pr-status: revision A PR awaiting follow-up work from its author after review labels Dec 15, 2023
@Anish9901
Copy link
Member

This is looking great @varshadr! Can you add some tests to verify that the validator is working as intended?

@varshadr
Copy link
Contributor Author

This is looking great @varshadr! Can you add some tests to verify that the validator is working as intended?

Hey @Anish9901
I have never written tests before, I'll give it a try though!

@seancolsen seancolsen added pr-status: revision A PR awaiting follow-up work from its author after review and removed pr-status: review A PR awaiting review labels Jan 3, 2024
@seancolsen seancolsen modified the milestones: Backlog, v0.1.4 Jan 3, 2024
@seancolsen
Copy link
Contributor

seancolsen commented Jan 3, 2024

I put this in the v0.1.4 milestone because we'd like to Clean up django migrations before 0.1.4 release and this PR introduces migrations (so we want to merge it before we clean up the migrations).

@Anish9901
Copy link
Member

@varshadr for the sake of merging this PR I am taking over writing the test cases, please let me know if you have any concerns.

@varshadr
Copy link
Contributor Author

varshadr commented Jan 3, 2024

@varshadr for the sake of merging this PR I am taking over writing the test cases, please let me know if you have any concerns.

Sure, you could go on with it

@Anish9901 Anish9901 dismissed stale reviews from mathemancer and silentninja January 3, 2024 22:34

Review addressed

@Anish9901 Anish9901 added this pull request to the merge queue Jan 3, 2024
Merged via the queue into develop with commit 596e756 Jan 3, 2024
19 checks passed
@Anish9901 Anish9901 deleted the 3176-update-constraints-for-positive-integers-in-oid-and-column_order branch January 3, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: revision A PR awaiting follow-up work from its author after review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Update Constraints for Positive Integers in oid and column_order
6 participants