New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated oid
and column_order
fields to only allow positive integers
#3177
Updated oid
and column_order
fields to only allow positive integers
#3177
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@varshadr Please run makemigrations
to generate the migration file for converting the existing database columns and add it to the PR.
Okay 👍 |
@varshadr I'm re-assigning this to @mathemancer because Mukesh will no longer be working with you on this project. Please assign any further PRs to @mathemancer for review. |
Sure 👍 |
This is looking great @varshadr! Can you add some tests to verify that the validator is working as intended? |
Hey @Anish9901 |
I put this in the v0.1.4 milestone because we'd like to Clean up django migrations before 0.1.4 release and this PR introduces migrations (so we want to merge it before we clean up the migrations). |
@varshadr for the sake of merging this PR I am taking over writing the test cases, please let me know if you have any concerns. |
Sure, you could go on with it |
Review addressed
Fixes #3176
This PR addresses constraints for the
oid
field and thecolumn_order
field in the TableSettings object. Both fields currently allow negative integers. This update ensures thatoid
andcolumn_order
only accepts positive integers.Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin