Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed : upgraded to a newer version of psycopg2-binary #3201

Conversation

raisachatterjee
Copy link
Contributor

@raisachatterjee raisachatterjee commented Sep 8, 2023

Fixes #3148

Technical details

A newer version of the package psycopg2-binary is available. This PR aims to upgrade the version of the mentioned package to the latest.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@rajatvijay
Copy link
Contributor

@raisachatterjee Please fix the formatting of the checklist in the PR description.

@rajatvijay rajatvijay added the pr-status: revision A PR awaiting follow-up work from its author after review label Sep 22, 2023
@rajatvijay rajatvijay added this to the Backlog milestone Sep 22, 2023
@seancolsen seancolsen modified the milestones: Backlog, v0.1.4 Oct 2, 2023
@seancolsen
Copy link
Contributor

  • I edited the PR description to fix the list syntax.

    As such, I've unassigned @raisachatterjee

    @rajatvijay I would suggest that in the future we avoid delaying the review of PRs for such pedantic technicalities, especially when the PR is fixing a user-reported issue, as this one is.

  • Because this PR is fixing a user-reported issue, I've placed it in the 0.1.4 milestone, with the hope that review/merge will be quick and straightforward, given that this is a one-line change. We can bump it to the next release if it requires more work.

  • @dmos62 I've assigned this to you to review because my guess is that you have the most availability of all the back-end engineers at the moment. Please re-assign to someone else if I'm wrong.

@seancolsen seancolsen assigned dmos62 and unassigned raisachatterjee Oct 2, 2023
@seancolsen seancolsen added pr-status: review A PR awaiting review and removed pr-status: revision A PR awaiting follow-up work from its author after review labels Oct 2, 2023
Copy link
Contributor

@dmos62 dmos62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App boots as expected in dev mode.

@dmos62 dmos62 added this pull request to the merge queue Oct 3, 2023
Merged via the queue into mathesar-foundation:develop with commit 8b5a76f Oct 3, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Upgrade to newer version of psycopg2
4 participants