New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade node version, remove Storybook #3214
Conversation
1261a51
to
3f63757
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, works well.
@pavish I'll leave it to you to merge when you feel that all reviews are satisfied. Also it seems like it would be good for you to send out an email notification with this change, alerting devs that they'll need to rebuild their Docker containers.
ARG BUILD_PG_MAJOR=15 | ||
ENV PG_MAJOR=$BUILD_PG_MAJOR | ||
|
||
# Install dependencies | ||
RUN apt-get update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to remove the /var/lib/apt/lists/*; \
using rm -rf /var/lib/apt/lists/*; \
to avoid bloating the docker image. This can be fixed later when trying to reduce the docker image size too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I think we could do that later when focusing on reducing the docker image size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @pavish! I leave it to you to merge the pull request.
Fixes #3208
Technical details
Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin