Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node version, remove Storybook #3214

Merged
merged 9 commits into from Sep 28, 2023
Merged

Upgrade node version, remove Storybook #3214

merged 9 commits into from Sep 28, 2023

Conversation

pavish
Copy link
Member

@pavish pavish commented Sep 19, 2023

Fixes #3208

Technical details

  • Upgrades Node version to 18 (the latest lts version)
  • Removes Storybook
    • Existing Storybook version no longer works with Node 18
    • Upgrading Storybook requires react as a mandatory dev dependency. Storybook is already heavily bloated and newer versions seem to add more to it.
    • It was discussed and decided in Matrix chats to not use Storybook and migrate to a different component playbook. This is tracked here: Migrate to Storybook alternative #3215
    • Since the storybook commands no longer work with the Node version upgrade, it made more sense to remove Storybook in this PR.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@pavish pavish marked this pull request as ready for review September 19, 2023 18:02
@pavish pavish added the pr-status: review A PR awaiting review label Sep 19, 2023
@rajatvijay rajatvijay added this to the v0.1.4 milestone Sep 22, 2023
Copy link
Contributor

@seancolsen seancolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works well.

@pavish I'll leave it to you to merge when you feel that all reviews are satisfied. Also it seems like it would be good for you to send out an email notification with this change, alerting devs that they'll need to rebuild their Docker containers.

@seancolsen seancolsen removed their assignment Sep 27, 2023
ARG BUILD_PG_MAJOR=15
ENV PG_MAJOR=$BUILD_PG_MAJOR

# Install dependencies
RUN apt-get update
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to remove the /var/lib/apt/lists/*; \ using rm -rf /var/lib/apt/lists/*; \ to avoid bloating the docker image. This can be fixed later when trying to reduce the docker image size too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I think we could do that later when focusing on reducing the docker image size.

Copy link
Contributor

@silentninja silentninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @pavish! I leave it to you to merge the pull request.

@silentninja silentninja removed their assignment Sep 28, 2023
@silentninja silentninja added pr-status: revision A PR awaiting follow-up work from its author after review and removed pr-status: review A PR awaiting review labels Sep 28, 2023
@pavish pavish added this pull request to the merge queue Sep 28, 2023
Merged via the queue into develop with commit 208190a Sep 28, 2023
19 checks passed
@pavish pavish deleted the upgrade_node branch September 28, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: revision A PR awaiting follow-up work from its author after review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Upgrade node version to lts version: 18
4 participants