Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Close on overlay click -ModalRecordSelector #3217

Closed

Conversation

FidalMathew
Copy link
Contributor

@FidalMathew FidalMathew commented Sep 20, 2023

Fixes #3207

This PR fixes the on-click overlay issue for ModalRecordSelector. The issue is resolved using appropriate z-index values for components.

Screenshots
CPT2309201127-1015x692

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow [best practices][best_practices].
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@FidalMathew
Copy link
Contributor Author

@seancolsen The PR contains some local development changes, shall I remove them? The main changes include 2 files:

  • mathesar_ui/src/systems/record-selector/ModalRecordSelector.svelte
  • mathesar_ui/src/systems/record-selector/RecordSelectorWindow.svelte

I see that there's a linting error, it can be solved using the lint.sh command right?
Let me know if any changes are required. Thank you!

@seancolsen seancolsen self-assigned this Sep 20, 2023
@seancolsen seancolsen added the pr-status: review A PR awaiting review label Sep 20, 2023
@seancolsen
Copy link
Contributor

@FidalMathew yes, for this PR and for others in general: please make the diff as small as possible to fix the issue, and please ensure there are no linting errors.

@seancolsen
Copy link
Contributor

Closed in favor of #3220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

The "Record Selector" modal close when clicking on the overlay.
2 participants