Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Close on overlay click -ModalRecordSelector #3220

Merged
merged 9 commits into from
Oct 27, 2023
Merged

bug: Close on overlay click -ModalRecordSelector #3220

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c18df79
bug: Close on overlay click -ModalRecordSelector
FidalMathew Sep 20, 2023
f632abe
Merge branch 'develop' into new-issue_3217
seancolsen Sep 26, 2023
8ebcfb2
Merge branch 'centerofci:develop' into new-issue_3217
FidalMathew Sep 28, 2023
9571963
fix: Nested RecordSelector Modal overlay click close
FidalMathew Sep 28, 2023
11d2d31
Merge branch 'new-issue_3217' of https://github.com/FidalMathew/mathe…
FidalMathew Sep 28, 2023
1bbfd7a
fix: lint issues
FidalMathew Sep 28, 2023
3c8f0ba
fix: Convert let to const
FidalMathew Sep 29, 2023
2f6ba73
Merge branch 'develop' into new-issue_3217
seancolsen Oct 27, 2023
4ca3ca3
Use event capture instead of local variable
seancolsen Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion mathesar_ui/src/systems/record-selector/ModalRecordSelector.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,16 +96,17 @@
.window-positioner {
width: 100%;
flex: 1 0 max-content;
z-index: 2;
display: flex;
flex-direction: column;
align-items: center;
justify-content: flex-start;
overflow: hidden;
padding: 1rem;

.root-record-selector,
:global(.nested-record-selector) {
position: relative;
z-index: 2;
max-height: 100%;
display: flex;
flex-direction: column;
Expand Down
1 change: 0 additions & 1 deletion mathesar_ui/src/systems/record-selector/RecordSelectorWindow.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@
display: flex;
flex-direction: column;
overflow: hidden;
padding: 1rem;
}
.overlay {
position: absolute;
Expand Down