Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MATHESAR_CLIENT_DEV_URL configurable via .env #3229

Merged
merged 2 commits into from Oct 5, 2023

Conversation

dmos62
Copy link
Contributor

@dmos62 dmos62 commented Oct 3, 2023

Allows setting MATHESAR_CLIENT_DEV_URL in the .env file. I sometimes need this when working out of a remote box.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dmos62 dmos62 added the affects: dx Related to developer experience label Oct 3, 2023
@dmos62 dmos62 added this to the High priority milestone Oct 3, 2023
@dmos62 dmos62 requested review from silentninja and mathemancer and removed request for silentninja October 3, 2023 14:30
Copy link
Contributor

@silentninja silentninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as it is needed for development workflow and doesn't break anything!

@silentninja silentninja added this pull request to the merge queue Oct 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 3, 2023
@dmos62 dmos62 added this pull request to the merge queue Oct 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 3, 2023
@silentninja silentninja added this pull request to the merge queue Oct 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 4, 2023
@silentninja silentninja added this pull request to the merge queue Oct 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 4, 2023
@dmos62 dmos62 added this pull request to the merge queue Oct 5, 2023
@dmos62
Copy link
Contributor Author

dmos62 commented Oct 5, 2023

What's happening with the merge queue? You'd expect this PR to have no effect on any check.

Merged via the queue into develop with commit 9773c11 Oct 5, 2023
8 checks passed
@dmos62 dmos62 deleted the make-client-dev-url-configurable-via-env branch October 5, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: dx Related to developer experience
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants