Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added formatting to values in DateTimeCell #3332

Conversation

dikwickley
Copy link

Fixes #1889

It simply uses the formatter passed in DateTimeCell to parse the value & the searchValue so they are consistent.

Screenshots

image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@pavish pavish self-assigned this Dec 4, 2023
@pavish pavish added the pr-status: review A PR awaiting review label Dec 4, 2023
@pavish pavish added this to the Backlog milestone Dec 4, 2023
Copy link
Member

@pavish pavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dikwickley I'm closing this PR as the changes here break the functionality of DateTime cells. Please feel free to open a new PR when the issue is fixed.

</script>

<SteppedInputCell
bind:value
bind:value={formattedValue}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dikwickley This binding will break the entire functionality of this cell.

Try creating a Date & Time column in a table, and modifying the value in it. You'll notice that the cell no longer displays the value, in your PR.

Please refer the svelte docs on how bind works, and notice that there's already a prop called formatValue which is passed to the SteppedInputCell for the purpose of formatting content. Also when a change is made to a component, make sure to test all places that utilize it. In this scenario, this component is used as the cell in tables and explorations.

@pavish pavish closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Highlight matching cells in temporal cell types within the Record Selector
2 participants