New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate /src/systems, support passing arguments to RichText slots #3340
Conversation
…ctor instead of top level constants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pavish I'm reviewing the RichText component changes only.
I like the spirit of the changes to RichText. But I have some concerns with the syntax (which I recall expressing when you introduced this idea to me on a call).
The syntax [linkComponent](here)
looks so much like a markdown hyperlink that I'm worried editors will mix up the order of linkComponent
and here
. I can see why you chose that order though — it's in keeping with putting the component name in the square brackets. I think on our call I had proposed reversing them with a syntax like [here](linkComponent)
, but I can see how that would also be confusing because the square brackets would be inconsistent with our existing RichText syntax — so I rescind that proposal.
What do you think about using one of these alternate syntaxes:
Click [linkComponent(here)] for more information.
Click [linkComponent:here] for more information.
Click [linkComponent here] for more information.
@seancolsen I thought a bit about this syntax. The major concern I wanted to address is to ensure that translators know that anything within square brackets The alternative syntaxes you've provided would make it confusing to translators.
I'm not concerned about this as much as these strings are only mentioned in a json file. I'm not sure if this is a concern we should address. Having said that, I'm open to brainstorming a better syntax. I'd like to do that separately from this PR though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pavish and I chatted on a call about this.
Our plan: We are going to merge this in as-is and then be sure to re-visit the syntax questions before we hire people to perform the translation work. We may decide to re-think the syntax within RichText component more broadly once we have a clearer idea of all the cases it needs to handle. At that point, if we make changes to the syntax, then we'll implement those syntax changes (modifying all the strings) before training any translators on it.
This PR:
/src/systems
.Notes for reviewers:
Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin