Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug while deleting the database connection #3377

Conversation

Taherpatrawala
Copy link
Contributor

@Taherpatrawala Taherpatrawala commented Dec 31, 2023

Related to #3361

When we get a del_msar_schema from the client side we get a string value "true"/"false" hence the condition to check this variable always considers it to be true and deletes the database connection, so I made another check further to check the string value.
I am unsure whether I should change the exception after hearing from @mathemancer

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@seancolsen seancolsen added the pr-status: review A PR awaiting review label Jan 2, 2024
@Anish9901
Copy link
Member

Good work so far @Taherpatrawala! I've updated the expected behavior for part 2 of the issue factoring in @mathemancer's comment about the error behavior, please take a look.

@seancolsen seancolsen added pr-status: revision A PR awaiting follow-up work from its author after review and removed pr-status: review A PR awaiting review labels Jan 3, 2024
@Anish9901
Copy link
Member

@Taherpatrawala issue #3361 is a high priority for us, could you make the required changes within a couple of days?

@Taherpatrawala
Copy link
Contributor Author

@Anish9901 On it! Should I create a separate exception in database_exceptions/exceptions.py ?

@Anish9901 Anish9901 force-pushed the 3361-bugs-while-deleting-database branch from fc8836e to 4b138eb Compare January 4, 2024 13:27
Copy link
Member

@Anish9901 Anish9901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Taherpatrawala We've decided to handle Part 2 of the issue in a subsequent PR, your implementation of Part 1 of the issue looks good, and I've added a test in 4b138eb to ensure that it works as intended.

Thanks for your contribution!

@Anish9901 Anish9901 added this pull request to the merge queue Jan 4, 2024
Merged via the queue into mathesar-foundation:develop with commit 139d335 Jan 4, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: revision A PR awaiting follow-up work from its author after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants