Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix active cell displaying above row header cell #3382

Merged

Conversation

catfo435
Copy link
Contributor

@catfo435 catfo435 commented Jan 3, 2024

Fixes #3380

Fixes the issue by changing the z-index value of the top-left-cell from 3 to 5.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@seancolsen
Copy link
Contributor

@catfo435, I just wanted you to know that I'm still planning to review this PR but that work is queued behind several higher priority tasks at the moment. I can't promise when I'll be able to review this, but I'll definitely get to it.

@seancolsen
Copy link
Contributor

seancolsen commented Jan 12, 2024

Note to self for review: PRs #3393 and #3419 coincidentally proposed exactly this same fix.

@seancolsen seancolsen mentioned this pull request Feb 1, 2024
7 tasks
@seancolsen seancolsen changed the title Changed Z-index of top-left-cell from 3 to 5 Fix active cell displaying above row header cell Feb 1, 2024
Copy link
Contributor

@seancolsen seancolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @catfo435

@catfo435
Copy link
Contributor Author

catfo435 commented Feb 1, 2024

No problem! @seancolsen

@seancolsen seancolsen added this pull request to the merge queue Feb 1, 2024
Merged via the queue into mathesar-foundation:develop with commit 6d73a93 Feb 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Active/Focused Cell is displayed over the Row Number Cell
2 participants